Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make progress on good code formatting and style with CodeClimate #130

Open
jywarren opened this issue Apr 26, 2018 · 6 comments
Open

Make progress on good code formatting and style with CodeClimate #130

jywarren opened this issue Apr 26, 2018 · 6 comments

Comments

@jywarren
Copy link
Member

https://codeclimate.com/github/publiclab/leaflet-blurred-location has a bunch of suggestions to improve the code base -- let's plan for some of this over the summer!

@jywarren
Copy link
Member Author

@mridulnagpal -- this is a great resource for making code more maintainable and readable. I know you're working on a few things already but keep this in mind in your summer schedule! It has a lot of good potential first-timers-only issues you could make as well.

@mridulnagpal
Copy link
Member

Awesome, on it!!

@jywarren
Copy link
Member Author

jywarren commented Jun 6, 2018

This is also a great next step. Let's get that score up!

@jywarren
Copy link
Member Author

jywarren commented Jul 3, 2018

How's this going, Mridul? Need some next steps?

@jywarren
Copy link
Member Author

jywarren commented Jan 7, 2019

Hi @gauravano and @sagarpreet-chadha -- I am thinking we might ask some new contributors interested in JavaScript to try some of these?

https://codeclimate.com/github/publiclab/leaflet-blurred-location/issues?category=complexity&engine_name%5B%5D=structure&engine_name%5B%5D=duplication lists a lot of recommendations and has tips on how to fix them:

image

What do you think?

@jywarren
Copy link
Member Author

jywarren commented Jan 7, 2019

And also tests are being coordinated here: #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants