Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getblurryscale() undefined error resolved AND changing LBL syntax #195

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

getblurryscale() undefined error resolved AND changing LBL syntax #195

wants to merge 6 commits into from
+170 −99

Conversation

sagarpreet-chadha
Copy link
Collaborator

Fixes #194 , #193 😄 .

Work in Progress 🚧 👷 !

@sagarpreet-chadha sagarpreet-chadha added ready Ready to be merged ! review-me and removed in progress labels Apr 8, 2019
@sagarpreet-chadha
Copy link
Collaborator Author

Hi @jywarren ,
This PR changes the syntax of LBL declaration to the same way a standard Leaflet object is added .

var map123 = L.map('map').setView([23,77] , 3) ;

var blurredLocation = new BlurredLocation(options) ;
blurredLocation.addTo(map123) ;

Kindly review 😄 !

@sagarpreet-chadha sagarpreet-chadha mentioned this pull request Apr 8, 2019
Open
@jywarren
Copy link
Member

jywarren commented Apr 9, 2019

Awesome! Let's update the docs too!

@jywarren
Copy link
Member

jywarren commented Apr 9, 2019

Is this a breaking change regarding https://semver.org?

@jywarren
Copy link
Member

jywarren commented Apr 9, 2019

If not, let's merge! If so, maybe we need to update the version number first. Thanks!!!

@jywarren
Copy link
Member

jywarren commented Apr 9, 2019 via email

@igniteeng000
Copy link
Member

@jywarren is this gif fine for demo implementation of synchronous editing.

@sagarpreet-chadha
Copy link
Collaborator Author

sagarpreet-chadha commented Apr 9, 2019 •
edited
Loading

Hi @jywarren , updated readme and version number is already in the PR 😄 .

I have changed the version number from 1.2.8 to 1.3.0 but i guess we are introducing backwards incompatible change , so we should change version to 2.0.0 according to https://semver.org/ .

Thank you !

PS : I would be writing detailed documentation in accordance to publiclab/leaflet-blurred-location-display#64 later .

@sagarpreet-chadha sagarpreet-chadha mentioned this pull request Apr 18, 2019
Closed
11 tasks
@jywarren
Copy link
Member

+1 v2.0!!! Thank you!!!

@sagarpreet-chadha
Copy link
Collaborator Author

Done 👍 . Should we merge this ? Thanks You !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren Awaiting requested review from jywarren

Assignees
No one assigned
Labels
ready Ready to be merged ! review-me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] TypeError: getBlurryScale(...) is undefined .
3 participants
@sagarpreet-chadha @jywarren @igniteeng000