Incorporate "node-geocoder" #182
Conversation
>>
>> ###
>> ### The "request" library is not installed automatically anymore.
>> ### But is a dependency of "request-promise".
>> ### Please install it with:
>> ### npm install request --save
>> ###
>> at
>> dist/Leaflet.BlurredLocation.js:63099Doing |
| "os-tmpdir": "^1.0.0" | ||
| } | ||
| }, | ||
| "path-is-abso |
There was a problem hiding this comment.
ah, here this seems to be a new req. So is it saying just to add request to our package.json?
There was a problem hiding this comment.
@jywarren, yep. I tried including the request-promise in the dev deps too and wrapped up geocode.reverse in the same (var wrapper = require('request-promise') then wrap using wrapper). But no luck there.
There was a problem hiding this comment.
However, it is worth noting that all the tests pass when I employ an alternative for the geocode.reverse method, be it the original ajax snippet, a native promise, or a custom one from npm libs.
|
Hmm, this is odd. is this a recent change in |
|
Hmm. I wonder if anyone from @publiclab/is-reviewers would be able to offer input here? Folks there are really good at JS issues and maybe would notice something. |
Will fix #81 once done, WIP. Started off by documentinggetPlacenameFromCoordinatesinGeocoding.js.Fixes #81.
/cc @jywarren