Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize server setup #9

Open
5 tasks
rexagod opened this issue Aug 26, 2019 · 7 comments · May be fixed by #17
Open
5 tasks

Localize server setup #9

rexagod opened this issue Aug 26, 2019 · 7 comments · May be fixed by #17
Labels
first-timers-only

Comments

@rexagod
Copy link
Member

rexagod commented Aug 26, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update: In this one, you need to replace the (assumed) global live-server keyword by its respective node_modules path.

    matcher-cli/utils/matcher-init-query.js

    Line 3 in 0bf7186

    exports.matcherInitQuery = `live-server ${envVars.MATCHER_PATH} --no-browser --quiet --port=${envVars.PORT} &`;

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
@rexagod rexagod added good first issue Good for newcomers first-timers-only and removed good first issue Good for newcomers labels Aug 26, 2019
@MohamedAssaf
Copy link

Hello, I'm taking this issue I'll update it shortly.

@MohamedAssaf
Copy link

Hello, I'm very new at this so I could use some help
I edited the file to look like this :

const envVars = require('../.env_vars');
const path = require('path');
const liveServer = path.join('../node_modules', 'live-server');

exports.matcherInitQuery = ${liveServer} ${envVars.MATCHER_PATH} --no-browser --quiet --port=${envVars.PORT} &;

and I created a local branch but I got permission denied.
Now if you can help me out with two things:

  1. does this correctly address the issue?
    2)what to do with the permission denied that I'm getting

@moki298
Copy link

moki298 commented Sep 26, 2019 •
edited
Loading

Can you share more info regarding your permission denied error? Where exactly did you get this error? A picture snapshot or error stack trace would be helpful.

  1. path.join is not required here and at least the way you used it doesn't help. Use this instead:
    const liveServerNPMModulePath = require('../node_modules/live-server/live-server');

  2. If the permission denied error is occurring when you git commit, it's because you are trying to commit to publiclab/matcher-cli directly, instead you should try to fork the publiclab/matcher-cli first and then create a feature branch on your own repository and then do a pull request from your forked repo feature branch to the publiclab/macther-cli master branch. More on this here: https://publiclab.org/notes/warren/11-22-2017/use-git-and-github-to-contribute-and-improve-public-lab-software

Also @rexagod there appear to be some lint errors occurring in the matcher-summon.js file due to unused functions.

@ant-plotnikov
Copy link

ant-plotnikov commented Oct 1, 2019 •
edited
Loading

Hello @rexagod Could I take it in progress?
As I see husky prevents me from commit as per unused function declarations in src/matcher-summon.js. Should I remove them as well in a separate commit?

@moki298
Copy link

moki298 commented Oct 1, 2019

@ant-plotnikov I think you should go ahead and do a pull request. I am not sure about the unused code though.

@ant-plotnikov
Copy link

PR opened

@neeraj-2
Copy link

#17
I have attached here the pull request for the same.

@neeraj-2 neeraj-2 linked a pull request Oct 10, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
first-timers-only
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update matcher-init-query.js
5 participants
@moki298 @rexagod @MohamedAssaf @ant-plotnikov @neeraj-2