Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store tagLocations data #9997

Closed
wants to merge 4 commits into from
Closed

store tagLocations data #9997

wants to merge 4 commits into from

Conversation

daemon1024
Copy link
Member

@daemon1024 daemon1024 commented Aug 5, 2021 •
edited
Loading

Ref #9946 #9698

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Aug 5, 2021

@daemon1024 daemon1024 marked this pull request as draft August 5, 2021 19:46
@codecov
Copy link

codecov bot commented Aug 5, 2021 •
edited
Loading

Codecov Report

Merging #9997 (f055afd) into main (f41f8e7) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9997      +/-   ##
==========================================
+ Coverage   82.13%   82.19%   +0.05%     
==========================================
  Files          98       98              
  Lines        5968     5971       +3     
==========================================
+ Hits         4902     4908       +6     
+ Misses       1066     1063       -3
Impacted Files Coverage Δ
app/controllers/images_controller.rb 70.27% <100.00%> (ø)
app/controllers/notes_controller.rb 85.09% <100.00%> (+0.22%) ⬆️
app/helpers/application_helper.rb 87.62% <100.00%> (+2.21%) ⬆️
app/services/search_service.rb 95.00% <100.00%> (-0.10%) ⬇️
app/controllers/user_tags_controller.rb 83.78% <0.00%> (+1.35%) ⬆️

@codeclimate
Copy link

codeclimate bot commented Aug 5, 2021

Code Climate has analyzed commit f055afd and detected 0 issues on this pull request.

View more on Code Climate.

@daemon1024 daemon1024 mentioned this pull request Aug 5, 2021
Open
@Tlazypanda
Copy link
Collaborator

Hey @daemon1024 are we planning to roll this change out? Do let me know when it's ready ✌️

@daemon1024
Copy link
Member Author

Hey @Tlazypanda, thank you for reaching out. I don't think we will be proceeding this further for now. There's some discussion pending based on #9946 (comment) and yet to decide the path forward. We can close this PR and reopen later (if needed) once we have final path forward.

@stale
Copy link

stale bot commented Sep 27, 2022

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress label 🎉 . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! 💯 Thank you for your contributions! 🙌 🎈.

@stale stale bot added the stale label Sep 27, 2022
@stale stale bot closed this Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daemon1024 @Tlazypanda