Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning Issue : Sensor Data Upload and Display Library #26

Open
3 of 10 tasks
IshaGupta18 opened this issue May 20, 2019 · 9 comments
Open
3 of 10 tasks

Planning Issue : Sensor Data Upload and Display Library #26

IshaGupta18 opened this issue May 20, 2019 · 9 comments

Comments

@IshaGupta18
Copy link
Collaborator

IshaGupta18 commented May 20, 2019

Here's a checklist of what is left to do:

  • Integration with plots2

Model and Controller are ready. We need to establish routes and save files against the user.

  • Displaying per-user data

Once the integration with plots2 is complete, we can move to its page design and implementation.

  • Create charts from previously uploaded files

After integration, just have to list out the files uploaded by the user and normal flow resumes

  • Publish as a research note (Post Integration)

  • Browsable Time Slider (Work in progress) [Implemented through Plotly]

  • Add Graph feature from the same CSV (Work in progress)

  • Add multiple graphs from multiple CSVs (Work in progress)

  • Export Options (Discussion)
    Save as Image (done)
    Save as Excel spreadsheet (done)

  • More UI Designing (Work in progress)
    A decent design is ready, which is easy to understand and work with. We will be advancing towards
    the complete design a little later in the timeline, so that the functional stuff can be implemented and
    tested on priority.

  • Testing (WIP)
    Learning about testing and testing frameworks. Also, some code will be restructured and refactored,
    as the process of going through testing made me realize that the code can be structured for a better
    understanding of it, as that's one of the reasons why tests are written: To easily understand what
    the code aims to achieve.

@namangupta01 @jywarren what do you think is left and can be added here? Please feel free to! Thanks!

@jywarren
Copy link
Member

jywarren commented May 20, 2019 via email

@IshaGupta18
Copy link
Collaborator Author

IshaGupta18 commented May 20, 2019 via email

@IshaGupta18
Copy link
Collaborator Author

@jywarren we have importing feature from CSV URL (basically from a remote file). We can work for a big text area box for a string, and look up google spreadsheets too.

@IshaGupta18
Copy link
Collaborator Author

@jywarren as for importing data from a Google Sheet, we will need the user to sign in with the google, in order to access the user's data, so we will need a little planning around this.

If the user wants to upload a google sheet, they will simply have to sign in with a google account, and then we can access the sheet's data.

What do you think about this?

@jywarren
Copy link
Member

jywarren commented May 29, 2019 via email

@IshaGupta18
Copy link
Collaborator Author

So I tried and figured it out, and I found out, that for this to work, the sheet will have to be published on the web, something like what has been done at LEL:
Like here
image

Then we can fetch data without logging in.

The question here is, is it worth the user, to publish data that might be sensitive to them on the web v/s asking the user to login to grant access. The latter one involves more work, however, that might be a safer option to the user. But since the user is allowing us to access the file's data, they may not mind publishing on the web, though that will involve them doing some additional work before coming and using the library. It is basically a tradeoff. What do you think @jywarren ?

@IshaGupta18
Copy link
Collaborator Author

@IgorWilbert @geekychasser what do you think about this?

@SidharthBansal SidharthBansal changed the title Remaining Work for GSoC Planning Issue : Sensor Data Upload and Display Library Jun 5, 2019
@jywarren
Copy link
Member

jywarren commented Jun 5, 2019

I think perhaps we should offer some good guidance (with screenshots) on how to make it public, but simultaneously warn people what that will mean with regard to privacy. If they don't want to do it, they could just upload instead of using the Google Spreadsheets process.

@IshaGupta18
Copy link
Collaborator Author

IshaGupta18 commented Jun 6, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants