Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve linting errors #50

Open
5 tasks
rexagod opened this issue Jun 19, 2019 · 13 comments · May be fixed by #92
Open
5 tasks

Resolve linting errors #50

rexagod opened this issue Jun 19, 2019 · 13 comments · May be fixed by #92

Comments

@rexagod
Copy link
Member

rexagod commented Jun 19, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Problem

📋Solution

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update

// install ESLint
$ npm i -g eslint

// navigate and run linter
$ cd simple-data-grapher && eslint --fix .

// format code to fix linting errors

After the errors are fixed, proceed as specified below.

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@IshaGupta18
Copy link
Collaborator

This is great @rexagod ! We'll open a couple more of these!

@osbornetunde
Copy link

I claim this

@rexagod
Copy link
Member Author

rexagod commented Jun 20, 2019

@osbornetunde Go ahead, and let us know if you face any problems whatsoever. Thanks!

@IshaGupta18
Copy link
Collaborator

IshaGupta18 commented Jun 20, 2019 via email

@pherwanikar
Copy link

Hey can you add a WIP label to tickets that have already been picked up to make it clear that they are taken?

@hemang249
Copy link

Still Open for Solving ? Would like to have a go at this one

@IshaGupta18
Copy link
Collaborator

IshaGupta18 commented Sep 30, 2019 via email

@dsuarezlogans
Copy link

Hi @IshaGupta18, is this issue available to work on it?

@raksh07
Copy link

raksh07 commented Oct 19, 2019

Hi can I try this issue

@IshaGupta18
Copy link
Collaborator

IshaGupta18 commented Oct 20, 2019 via email

@alexandrosyiangou
Copy link

Hey! I would like to lend a hand on this as well! 🙂

@ovpv
Copy link

ovpv commented Oct 30, 2019

Hi, Can i try?

@IshaGupta18
Copy link
Collaborator

IshaGupta18 commented Oct 30, 2019 via email

@ovpv ovpv linked a pull request Oct 31, 2019 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants