Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find broken routes on the spectral workbench app and add them to a list here #833

Closed
Tracked by #801
Georjane opened this issue Jan 11, 2022 · 5 comments
Closed
Tracked by #801

Comments

@Georjane
Copy link
Collaborator

Georjane commented Jan 11, 2022

Hi @Tlazypanda @jywarren @TildaDares 👋🏽
Please I was wondering if there are any broken routes we might have come across on the SW or have been reported by users so I could reconnect them?
So far, after going through most of the links in the SW, most of the routes seem to be working great. I noticed just one broken link on the contributor's name in the spectra section whose issue I addressed here

Please are there other broken routes that I missed?
Thank you. 🙏🏽 🙏🏽🙏🏽

@Georjane
Copy link
Collaborator Author

List of broken routes

  • All author links (pzgeorjane) in the images below are broken
    image
    image
    image

@Georjane
Copy link
Collaborator Author

@TildaDares @jywarren @Tlazypanda
I keep seeing the letter h like <%=h in front of opening tags like in the image below. I wish to find out if this is a bug or there is a meaning to it. I have seen this in a couple of places. Thank you. 🙏🏽

app/views/macros/show.html.erb
image

@TildaDares
Copy link
Member

@Georjane <%= h is an alias for html_escape. It is used to escape HTML tags https://api.rubyonrails.org/classes/ERB/Util.html#method-c-h

@Georjane
Copy link
Collaborator Author

@Georjane <%= h is an alias for html_escape. It is used to escape HTML tags https://api.rubyonrails.org/classes/ERB/Util.html#method-c-h

oh, I see. it makes a lot of sense now. thank you @TildaDares

@Georjane
Copy link
Collaborator Author

Georjane commented Feb 9, 2022

@Tlazypanda
please what do we mean by looking at the blame view here,
you can see recently fixed ones in the "blame" view of https://github.com/publiclab/spectral-workbench/blame/main/config/routes.rb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants