Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some JS refactoring #58

Open
batpad opened this issue Dec 19, 2024 · 1 comment
Open

Some JS refactoring #58

batpad opened this issue Dec 19, 2024 · 1 comment

Comments

@batpad
Copy link
Collaborator

batpad commented Dec 19, 2024

Am making this ticket just to open the discussion, so I don't feel terrible implementing new features on top of the current structure.

I think my idea would be to:

  • Make an index.js and move that out of index.html
  • Use Javascript imports to import / export modules and keep things in separate files

I think with this light restructure, we can begin to start logically grouping the code a bit better, and still stay away from using a full-blown framework or any build process.

@pratapvardhan let know if you have any opinions on how we should structure this. Am happy to do this light touch refactor at some point, happy to add to the mess a bit for now :-) cc @planemad

@pratapvardhan
Copy link
Collaborator

No strong opinions. I'm thinking moving to ES modules is great, moving to /js folder might be good?

/js
 - featureControl.js
 - ..
 - utils.js
 - index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants