Add custom message type support #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguz-pubnub
requested review from
parfeon,
wkal-pubnub and
marcin-cebo
as code owners
jguz-pubnub
force-pushed
the
feat/add-message-type2
branch
from
e8987ac to
cb4c9b4
Compare
parfeon
approved these changes
Oct 22, 2024
| ) | ||
| case file( | ||
| message: FilePublishPayload, | ||
| customMessageType: String?, |
There was a problem hiding this comment.
@jguz-pubnub I'm wondering about this one. Don't see it in specs so far. I know that it should be the same as regular publis.
There was a problem hiding this comment.
Indeed, there's no mention about it in specs. I asked Smitha and here's the response I got. It works as you assumed:
The
/v1/files/publish-file/...endpoint translates to a publish endpoint in the server so thatcustom_message_typewill work exactly like thetypeparameter. No change
jguz-pubnub
force-pushed
the
feat/add-message-type2
branch
from
d8a08f3 to
458e1a6
Compare
jguz-pubnub
changed the title
|
@pubnub-release-bot release |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(message-type): add custom message type support
Add custom message type support for the following APIs: publish, signal, share file, subscribe, and history.