Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't enable sha224 with sha1 #1390

Open
apampurin opened this issue Jan 15, 2025 · 0 comments
Open

Can't enable sha224 with sha1 #1390

apampurin opened this issue Jan 15, 2025 · 0 comments

Comments

@apampurin
Copy link

apampurin commented Jan 15, 2025

Version
pulp-operator:v1.0.0-beta.4
pulp-operator:v1.0.0-beta.5

Describe the bug
I'm creating rpm repositiries for rhel9 and rhel7.
I successfully uploaded rhel9 repos.

Then, I tried to upload rhel7 repo which is required to add sha1 shecksum in pulp CR which I've done as follow:

spec:
  allowed_content_checksums:
  - sha1

After that I found that some already uploaded artifacts with sha224 were removing, so I stopped pulp-rpm-update-content-checksums pod.
I added sha224 and other to allowed_content_checksums like:

spec:
  allowed_content_checksums:
  - sha224
  - sha256
  - sha512
  - sha1
  - sha384

But handle-artifact-checksums job was not started.
I've got error in pulp-operator-controller-manager logs:

2025-01-15T13:39:44Z	INFO	controller/controller.go:217	Starting workers	{"controller": "pulprestore", "controllerGroup": "repo-manager.pulpproject.org", "controllerKind": "PulpRestore", "worker count": 1}
2025-01-15T13:39:44Z	WARN	repo_manager/precheck.go:276	Checksum sha1 is deprecated by some Pulp plugins, it is not recommended using it in production.
2025-01-15T13:39:44Z	ERROR	repo_manager/precheck.go:271	Checksum sha224 is not valid!
github.com/pulp/pulp-operator/controllers/repo_manager.checkAllowedContentChecksums
	/workspace/controllers/repo_manager/precheck.go:271
github.com/pulp/pulp-operator/controllers/repo_manager.prechecks
	/workspace/controllers/repo_manager/precheck.go:80
github.com/pulp/pulp-operator/controllers/repo_manager.(*RepoManagerReconciler).Reconcile
	/workspace/controllers/repo_manager/controller.go:100
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:116
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:303
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:263
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:224

I can return sha224 with removing allowed_content_checksums from pulp CR, and artifacts will be restored. But how I can activate sha1 and sha224?

I see related conversation in #1060, but I can't found answer to question above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant