-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue 3 Compatibility #166
Comments
Upvote. We need it. :) Please Please Please |
Hi, We're working on it but it's not there yet. The difficulty is not the migration/rewrite, it's to find free time to do it ! But it's on its way! We understand it's not ideal but it's the best we can do right now. |
I was toying around with this recently and resolved the incompatibility by running the plugin within my app and updating main.js to:
When I get a couple of minutes I can look at putting together a PR for you, in the meantime hopefully this helps. Edit: There were also a couple of deprecated commands to update too. |
Hi @sbathgate, Yes sure a PR would be welcome! |
Hello guys. I added vue 3 support and other functionality PR |
You will need to create the next branch and move the PR there, then you can publish with the tag next to npm. PR only works for vue3 |
@Sitronik hi, how to use your package after install? i have problems to useit... thanks! |
Hi, you can download code of package here: Example how to use in directory public -> index.html OR In you client entry point: import * as Vue from 'vue'
import App from './App.vue'
import VueTour from 'v3-tour'
require('v3-tour/dist/vue-tour.css')
const app = Vue.createApp(App)
app.use(VueTour) |
Doesn't seem to work for me @Sitronik with Vue3. |
Hello, show an example of the code you are using |
Trying to get it working with the Vue 3 Composition api, doesn't seem to work. import { createApp } from 'vue'
import App from './App.vue'
import router from './router'
import i18n from './locales'
import VueTour from 'v3-tour'
require('v3-tour/dist/vue-tour.css')
const app = createApp(App)
app.use(router).use(i18n).use(VueTelInput, globalOptions).use(VueTour).mount('#app') Component: <template>
<h1 data-v-step="0">Hello 👋</h1>
<v-tour name="myTour" :steps="steps"></v-tour>
</template> export default {
setup: () => {
const state = reactive({
steps: [
{
target: '[data-v-step="0"]', // We're using document.querySelector() under the hood
header: {
title: 'Get Started',
},
content: 'Discover <strong>Vue Tour</strong>!',
},
],
})
return {
...toRefs(state),
}
},
} Also tried with the old Option api as described in the documentation. |
Try changing target to id of html element should work <h1 id="step1">Hello 👋</h1> export default {
setup: () => {
const state = reactive({
steps: [
{
target: '#step1',
header: {
title: 'Get Started',
},
content: 'Discover <strong>Vue Tour</strong>!',
},
],
})
return {
...toRefs(state),
}
},
} I not tested with "document.querySelector() under the hood" |
Thanks for the reply! But changing the target to |
This is the rendered html output: <div class="v-tour" data-v-22ba47ca>
<!---->
</div>
<h1 id="step1" data-v-22ba47ca>Hello 👋</h1> I think it's not working because |
You are welcome. You need to add v-step component in html template as in example: Download code of https://github.com/Sitronik/v3-tour and run "serve" script and you will see everything works correctly in example |
Maybe I tested with old options api |
PRs are welcome) |
Ah yeah, you are using the old Options api, most packages that are updated for Vue 3 are compatible with the new Composition api. That's would be the confusion here. Thanks! |
You are welcome. I needed to quickly make support for vue 3 and I did not focus on the composition api, so you can send your PR with support) |
All work!! |
Found this which is fork with |
Hello, I found a way to work with composition API:
|
Hi! Still no Vue 3 support for this library? |
+1 for vue 3 support |
Any update here? |
I believe this project is dead but someone did fork it and make it compatible with Vue 3. I have been using it without any issues so far. |
Ok, i tested vue3-tour and v3-tour after we used vue-tour for 2 years (hope to get an update). vue3-tour has many changes and did not provide the same functions or even all the callbacks. So i would recommend v3-tour. https://github.com/Sitronik/v3-tour |
Hi!
What is the current status on Vue 3 compatibility? I'd be happy to test out a branch if there is one in development.
Thanks
The text was updated successfully, but these errors were encountered: