The generate function grabs stderr

[acco93]

Describe the Bug

The generate function grabs stderr.

Expected Behavior

I would expect only stdout to be retrieved.

Steps to Reproduce

$output = generate(command, arg1, arg2, ..., argN)

Environment

• Puppet 8
• Debian 12

Additional Context

Probably related to combine: true introduced in ee46e78

[github-actions]

Migrated issue to PUP-12086

[joshcooper]

@acco93 The generate function has always combined stdout and stderr

❯ cat /tmp/combine.sh 
#!/bin/bash

echo "Write to stdout" >&1
echo "Write to stderr" >&2 

❯ git checkout 8.6.0 && bundle update
...

❯ bundle exec puppet apply -e 'notice(generate("/tmp/combine.sh", "one", "two"))' 
Info: Loading facts
Info: Loading facts
Notice: Scope(Class[main]): Write to stdout
Write to stderr

Notice: Compiled catalog for localhost in environment production in 0.01 seconds
...

❯ git checkout main && bundle update
...

❯ bundle exec puppet apply -e 'notice(generate("/tmp/combine.sh", "one", "two"))'
Info: Loading facts
Info: Loading facts
Notice: Scope(Class[main]): Write to stdout
Write to stderr

Notice: Compiled catalog for localhost in environment production in 0.01 seconds
...

Note this is using puppet's execution implementation. Puppetserver uses a different implementation. If you're seeing the behavior in puppetserver, then I'd recommend enabling debug and you should see this message about them being combined before and after: https://github.com/puppetlabs/clj-shell-utils/blob/8a8ac4d60d3d65911a459b2af1df04684b31e5a4/src/java/com/puppetlabs/puppetserver/ShellUtils.java#L89

[acco93]

Got it, thanks for clarifying!