Add fix for package running dnf5 on fedora

[larhauga]

Hi,
on fedora 41 we experience the following errors due to the new dnf version, dnf5 (https://docs.fedoraproject.org/en-US/fedora/latest/release-notes/sysadmin/#dnf-5).

Error: Execution of '/usr/bin/dnf -d 0 -e 1 -y install XX' returned 2: Unknown argument "-d" for command "dnf5". Add "--help" for more information about the arguments.

The flags '-d' and '-e' have as a workaround been removed for newer versions of fedora.

This fixes #9506

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[CLAassistant]

All committers have signed the CLA.

[Stricken1670]

I just tested the PR, works great. Up next: group support.

hbo@habocp3 ~/Downloads %  sudo puppet agent -t
Info: Refreshing CA certificate
Info: CA certificate is unmodified, using existing CA certificate
Info: Refreshing CRL
Info: CRL is unmodified, using existing CRL
Info: Using environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Notice: Requesting catalog from puppet:8140 (10.10.8.6)
Notice: Catalog compiled by theforeman.example.com
Info: Caching catalog for habocp3.example.com
Info: Applying configuration version '1731659031'
Notice: /Stage[main]/Desktop_fedora::Gnome/Package[gnome-tweaks]/ensure: created
Notice: /Stage[main]/Desktop_fedora/Service[rpc-statd-notify.service]/ensure: ensure changed 'running' to 'stopped' (corrective)
Notice: /Stage[main]/Desktop_fedora::Gnome/Yum::Group[workstation-product-environment]/Exec[yum-groupinstall-workstation-product-environment]/returns: Unknown argument "groupinstall" for command "dnf5". Add "--help" for more information about the arguments.
Notice: /Stage[main]/Desktop_fedora::Gnome/Yum::Group[workstation-product-environment]/Exec[yum-groupinstall-workstation-product-environment]/returns: It could be a command provided by a plugin, try: dnf5 install 'dnf5-command(groupinstall)'
Error: 'yum -y groupinstall 'workstation-product-environment'' returned 2 instead of one of [0]
Error: /Stage[main]/Desktop_fedora::Gnome/Yum::Group[workstation-product-environment]/Exec[yum-groupinstall-workstation-product-environment]/returns: change from 'notrun' to ['0'] failed: 'yum -y groupinstall 'workstation-product-environment'' returned 2 instead of one of [0] (corrective)
Info: Class[Desktop_fedora::Gnome]: Unscheduling all events on Class[Desktop_fedora::Gnome]
Notice: /Stage[main]/Desktop_fedora::Rstudio/Package[rstudio]/ensure: created
Info: Stage[main]: Unscheduling all events on Stage[main]
Notice: Applied catalog in 21.83 seconds                                                                                                                                                                                                                                                                                   

[Stricken1670]

If I recall correctly, for dnf4, the old options were already deprecated. I don't know if dnf3 is still in use somewhere or how old it is, rocky linux 8 already uses dnf4. centos 7 also uses dnf4.

Perhaps we can do away with the conditionals altogether?

from the centos 7 dnf manpage:

       -e <error level>, --errorlevel=<error level>
              Error output level. This is an integer value between 0 (no error output) and 10 (shows all error messages), default is 3. Deprecated, use -v instead.

[larhauga]

@QWolfp3 how can I help in moving this PR along?

[Stricken1670]

@QWolfp3 how can I help in moving this PR along?

IMHO, we need a simple PR which does away with the deprecated settings. Those are settings from the RHEL6 era, which is no longer supported.

https://access.redhat.com/support/policy/updates/errata/

[larhauga]

@Stricken1670 I created a branch for removing the flags: https://github.com/puppetlabs/puppet/compare/main...larhauga:puppet:fix/main/dnf5-fedora41-remove-deprecated-flags?expand=1

It would be much cleaner and the best option if you think that we can break compatability here.
Should I create a new PR for that branch or update this? Any preferences?

I did not manage to find out where in the codebase the yum groupinstall comes from.

[thebeanogamer]

The calls to groupinstall are coming from https://github.com/voxpupuli/puppet-yum/blob/62b73b4c8989087367c4ac98037ed7c4d6e49562/manifests/group.pp, not Puppet itself. A separate PR will be needed for that repository.

[Stricken1670]

@larhauga
Thanks for the branch. Please create the PR.
I have no say in the matter, all I can do is share my humble opinion.