Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put_read_take test is not being run during tests #13

Open
JordanMartinez opened this issue Oct 12, 2018 · 2 comments
Open

put_read_take test is not being run during tests #13

JordanMartinez opened this issue Oct 12, 2018 · 2 comments

Comments

@JordanMartinez
Copy link
Contributor

While looking through AVar's test and trying them out myself, I noticed that one of the tests isn't even being run. I'm guessing that is a mistake:

In main, the middle one is missing

Including that test in main produces a failure

Not sure whether this is related to #9
@JordanMartinez
Copy link
Contributor Author

The tests works if one fixes the string. Rather than foobazfoobar, it should be barfoobazfoo

@natefaubion
Copy link
Contributor

Yeah, I think the string is just wrong. foobazfoobar would be the result if the put callback was called after it was taken, which is not correct. I'm not sure why it wasn't included. Maybe because it isn't an interesting test.

rgrover added a commit to rgrover/purescript-avar that referenced this issue May 25, 2019
@rgrover
fix purescript-contrib#13: run test_put_read_take from the test-suite
5054bec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@natefaubion @JordanMartinez