Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt5 port #22

Closed
wants to merge 2 commits into from
Closed

Qt5 port #22

wants to merge 2 commits into from

Conversation

Chemrat
Copy link

@Chemrat Chemrat commented Dec 5, 2016

This should resolve #14

Not sure if this can be merged right away because it breaks Qt4 support

  • If Qt4 support can be dropped, then built-in QScintilla should be either updated or just removed
  • If Qt4 support should be preserved, something should be done about bundled driver since the API of QSQLiteResult has changed, also CMakeLists will get complicated?

There's also a potential problem with QScintilla cmake module, because different distros may ship Qt5 version under different names

@Chemrat
rough Qt5 port
e206f2a 
internal QScintilla and sqldriver don't work for now
FindQScintilla.cmake probably won't work either
@Chemrat
port internal driver to Qt5
80f6267 
update FindQScintilla.cmake to build on Ubuntu Xenial
@jok-ts jok-ts mentioned this pull request Oct 21, 2017
Closed
@krytarowski
Copy link

Ping? This no longer builds anyway.

@rsachetto
Copy link

I've created a GitHub fork that implements the Qt5 version of sqliteman as this repository seems to be without activity.(https://github.com/rsachetto/sqliteman-qt5)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port to Qt5
3 participants
@Chemrat @krytarowski @rsachetto