You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discussed in #1179 many decomposition functions like Erbs require both GHI as some numeric type and a separate DOY or datetime series datetime_or_doy which can be either integer, float, numpy ndarray or pandas DatetimeIndex. It's likely that many users will pass GHI as a pandas series, and so it's possibly an extra burden to also pass datetime_or_doy, which could be simplified by reusing the index of GHI. EG:
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
As discussed in #1179 many decomposition functions like Erbs require both GHI as some numeric type and a separate DOY or datetime series
datetime_or_doy
which can be either integer, float, numpyndarray
or pandasDatetimeIndex
. It's likely that many users will pass GHI as a pandas series, and so it's possibly an extra burden to also passdatetime_or_doy
, which could be simplified by reusing the index of GHI. EG:If there's consensus we can update all decomposition methods in a single PR.
Beta Was this translation helpful? Give feedback.
All reactions