-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.9.5 release planning #1681
Comments
I will submit to close #1586 |
Based on the latest comments, I would not wait for #1658. |
I'm working on #1666 but computing the known solution for the test case is tedious. I wouldn't wait. |
I'd like to have #1695 included, it there are no objections. |
If we wait on #1666, then I'd like to push another release as soon as possible after this one. A hot fix. |
@kanderso-nrel oops sorry, I merged it already 🤷 |
What about #1687 in 0.9.5? It's currently marked for 0.10, but @mikofski and the contributor are resolving merge conflicts in 0.9.5, so there's some misaligned expectations. I am -1 on 0.9.5 given the lack of consensus on if it's a good idea and, from a quick look, a need to improve consistency with pvlib style (variable names, positional vs keyword args). |
I marked #1687 for v0.10 because the comments indicate a lack of consensus. |
I agree, let's push #1687 to v0.10. I'll communicate with contributor |
Keeping to the quarterly release schedule means releasing 0.9.5 sometime in mid March. I arbitrarily suggest March 15 for the target release date.
Looking through the v0.9.5 milestone, these PRs seem like they are close to being ready to merge and are thus candidates for inclusion:
model='gueymard2003'
toget_relative_airmass
#1655pvlib.bifacial.utils._vf_ground_sky_2d
acrosssurface_tilt
#1682Kicking down the road:
@pvlib/pvlib-core please review any PRs that interest you. I volunteer to solicit reviewers for PRs that don't attract attention on their own over the next couple weeks.
The text was updated successfully, but these errors were encountered: