Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.9.5 release planning #1681

Closed
7 of 12 tasks
kandersolar opened this issue Mar 2, 2023 · 10 comments · Fixed by #1699
Closed
7 of 12 tasks

v0.9.5 release planning #1681

kandersolar opened this issue Mar 2, 2023 · 10 comments · Fixed by #1699
Labels
Milestone

Comments

@kandersolar
Copy link
Member

kandersolar commented Mar 2, 2023

Keeping to the quarterly release schedule means releasing 0.9.5 sometime in mid March. I arbitrarily suggest March 15 for the target release date.

Looking through the v0.9.5 milestone, these PRs seem like they are close to being ready to merge and are thus candidates for inclusion:

Kicking down the road:

@pvlib/pvlib-core please review any PRs that interest you. I volunteer to solicit reviewers for PRs that don't attract attention on their own over the next couple weeks.

@kandersolar kandersolar added this to the 0.9.5 milestone Mar 2, 2023
@cwhanse
Copy link
Member

cwhanse commented Mar 2, 2023

I will submit to close #1586

@adriesse
Copy link
Member

adriesse commented Mar 2, 2023

Based on the latest comments, I would not wait for #1658.

@kandersolar
Copy link
Member Author

Assuming nobody objects, I'll plan to merge #1183 and #1682 tomorrow (March 17) and proceed with making the release. The other PRs in the list above are not ready yet, I think.

@cwhanse
Copy link
Member

cwhanse commented Mar 16, 2023

I'm working on #1666 but computing the known solution for the test case is tedious. I wouldn't wait.

@adriesse
Copy link
Member

I'd like to have #1695 included, it there are no objections.

@mikofski
Copy link
Member

If we wait on #1666, then I'd like to push another release as soon as possible after this one. A hot fix.

@mikofski
Copy link
Member

Assuming nobody objects, I'll plan to merge #1183 tomorrow (March 17) ...

@kanderso-nrel oops sorry, I merged it already 🤷

@wholmgren
Copy link
Member

What about #1687 in 0.9.5? It's currently marked for 0.10, but @mikofski and the contributor are resolving merge conflicts in 0.9.5, so there's some misaligned expectations. I am -1 on 0.9.5 given the lack of consensus on if it's a good idea and, from a quick look, a need to improve consistency with pvlib style (variable names, positional vs keyword args).

@cwhanse
Copy link
Member

cwhanse commented Mar 17, 2023

I marked #1687 for v0.10 because the comments indicate a lack of consensus.

@mikofski
Copy link
Member

I agree, let's push #1687 to v0.10. I'll communicate with contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants