Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trackpad/Mouse not working on touchscreen-notebooks #33

Open
bersling opened this issue Jan 10, 2017 · 1 comment
Open

Trackpad/Mouse not working on touchscreen-notebooks #33

bersling opened this issue Jan 10, 2017 · 1 comment

Comments

@bersling
Copy link

For users with a touchscreen-notebook the trackpad / mouse aren't working. I think this is because of line 229 of of https://github.com/pwambach/angular-canvas-painter/blob/master/js/pwCanvas.js because it uses if (!isTouch) {, meaning if a device has touch AND non-touch it won't work?

@pwambach
Copy link
Owner

Hey,

thanks for the hint. I didn't have this case in mind when I was building this project :) Sadly I don't have any time to dive back into the code. I guess you would have to normalize and handle both mouse and touch events equally and not decide between them.

PRs are welcome!

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants