Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not saving PNG from .cube #1

Open
ofou opened this issue Apr 8, 2021 · 3 comments
Open

Not saving PNG from .cube #1

ofou opened this issue Apr 8, 2021 · 3 comments

Comments

@ofou
Copy link

ofou commented Apr 8, 2021

Just checking out here, but what a great tool!

I was looking for something like this for doing batch processing to a bunch of .cube to .haldclut but it's not working for me.
Are you working on it? Do you have plans to release it?
I'll dig into the code to see what's going on. 🕵🏻‍♂️

@pwnage101
Copy link
Owner

IIRC, I only ever really built this tool to convert .haldclut to .cube, but none of the other ones (cube->hald, cube->3dl, 3dl->cube, hald->3dl, 3dl->hald, etc.). For some reason I also wanted to build the tool to allow those other conversion paths to be written later, but my needs were fulfilled after the first one, unfortunately.

@pwnage101
Copy link
Owner

If I'm reading my own code correctly, three methods are not implemented:

from_3dl(), to_haldclut(), and from_cube() are unimplemented, which means this tool cannot parse .3dl, write .png (hald), nor parse .cube. That means this tool as written CAN do the following:

  • hald -> cube
  • hald -> 3dl

but, it CANNOT do the following:

  • cube -> hald (write_cube() and write_hald() needs to be implemented)
  • cube -> 3dl (from_cube() needs to be implemented)
  • 3dl -> hald (from_3dl() and write_hald() needs to be implemented)
  • 3dl -> cube (from_3dl() needs to be implemented)

@pwnage101
Copy link
Owner

I just pushed up my latent local changes which apparently fixed 2 bugs. I have used this version with success, and my Blackmagic Video Assist monitor was able to read the .cube file that cluttool generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants