Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for contributors #574

Closed
FFY00 opened this issue Oct 21, 2019 · 18 comments
Closed

Looking for contributors #574

FFY00 opened this issue Oct 21, 2019 · 18 comments

Comments

@FFY00
Copy link
Member

FFY00 commented Oct 21, 2019

The state of this project has not been great in the last few years. A bit of history: This repo used to be owned by @pwr. A few years he got inactive, locking up administration privileges. Because of this it was impossible to add new maintainers and ultimately everything fell into the shoulders of @Lekensteyn. This was obviously not great as it is too much work for a single person to handle, especially as an hobby project! Needless to say this took a toll on the project, accumulating a lot of open issues.

Thankfully, around 4 months ago we were able to reach @pwr and move the repo to the https://github.com/pwr-Solaar organization! After this I stepped up as a maintainer, in hope to lift @Lekensteyn of many of his burdens. This was a step in the right direction but unfortunately both me and @Lekensteyn are still not enough to properly maintain this project. Because of this we are looking for new people to help out with that.

If anyone is wiling to become a maintainer you can start by triaging the issues on the bugtracker. Help people debugging issues, try to solve simple issues and send PRs. You can mention me in the issues if you have any technical questions, mainly regarding the protocol, and/or need some hardware tested, since I have a bunch of devices (see https://github.com/libratbag/libratbag/wiki/Devices).

Thank you everyone!

@rathann
Copy link
Contributor

rathann commented Oct 31, 2019

Thanks for stepping up. As an owner of a couple of Unifying devices, I recently took over maintenance of solaar package in Fedora and updated it to the latest release. It's still not ideal, but far better than what it was a year ago. I can offer some limited help with quality bug reports and triaging as part of my package maintenance work and spread the word that the project needs help.

@FFY00
Copy link
Member Author

FFY00 commented Oct 31, 2019

Thank you! I think what we really need is manpower. Helping out with triaging would be awesome! I can assist on the technical matters of the protocol but I really don't have time to go through the issues. Maybe I'll have some time around Christmas because I sort of get a break from college.

@alvgalrus
Copy link

I could lend a hand sometimes, most of the questions are just "I installed 0.9.2 and I'm missing options" anyway... I also have access to three different Logitech wireless mice (G305, MX Anywhere, MX Master).

@FFY00
Copy link
Member Author

FFY00 commented Dec 1, 2019

Other thing new contributors could do: #582

Figure out which features are available on your device and not yet implemented and try to add support.

@FFY00
Copy link
Member Author

FFY00 commented Dec 5, 2019

Other thing people can help with: #591

Refactor the documentation.

@pfps
Copy link
Collaborator

pfps commented Dec 17, 2019

I've added closure comments to a few bug reports.
I'm also trying to get receiver c534 to pair better.
Better documentation on current HID++ protocols would help a lot.

@FFY00
Copy link
Member Author

FFY00 commented Dec 17, 2019

Thank you!

Better documentation on current HID++ protocols would help a lot.

I will get on that.

@drupal-daffie
Copy link
Contributor

Better support for MX Master 3.

@pfps
Copy link
Collaborator

pfps commented Jan 18, 2020

As python2.7 is officially deprecated I suggest dropping support for it in solaar. A bit in the documentation saying so and maybe something added to the installation script is probably needed if so.

@FFY00
Copy link
Member Author

FFY00 commented Jun 28, 2020

Since @pfps stepped up, this is no longer an issue. It would still be great to get more people contributing though. I propose closing this, @pfps what do you think?

@pfps
Copy link
Collaborator

pfps commented Jun 28, 2020

@FFY00 It would be nice to have testers that would test out changes. A couple of people are willing, but more would be useful.

@FFY00 FFY00 changed the title Looking for a new maintainer Looking for contributors Jun 28, 2020
@FFY00
Copy link
Member Author

FFY00 commented Jun 28, 2020

Alright, I've renamed the issue.

@sk8geek
Copy link

sk8geek commented Jun 28, 2020

Hi, thanks for the continued work on this project. I have MX Keys (and an M350 Pebble mouse), happy to help with testing against that. Would like to help with code but I'm a Java dev so not familiar with Python. I want to understand an issue with my keyboard backlight coming on every few seconds so have spent some time in Wireshark looking through USB packets. I don't think it's Solaar related. Cheers.

@barolo
Copy link

barolo commented Jun 28, 2020

Hi, thanks for the continued work on this project. I have MX Keys (and an M350 Pebble mouse), happy to help with testing against that. Would like to help with code but I'm a Java dev so not familiar with Python. I want to understand an issue with my keyboard backlight coming on every few seconds so have spent some time in Wireshark looking through USB packets. I don't think it's Solaar related. Cheers.

@sk8geek you should move your issues to a separate thread, we've been working on MX Keys which is pretty much identical to Craft [ minus its crown ]

@pfps
Copy link
Collaborator

pfps commented Jun 28, 2020

If you are already watching all conversations for this repository you should be receiving messages about new pull requests. Checking these messages and testing those PRs that are relevant would be very useful. I'll try to add a comment about what hardware is needed to test the PR. Many PRs can be at least partially tested with any hardware.

@pfps
Copy link
Collaborator

pfps commented Jun 30, 2020

I added a new label to be used in pull requests - Ready for testing. I'm also adding in comments on what is needed to test the pull request. Hopefully you have seen a couple of comments - feel free to test out these pull requests. The easiest way to test a pull request is to fetch it into your clone of Solaar via:

git fetch origin pull/XXX/head:pull_XXX
git checkout pull_XXX

where XXX is the number of the pull request.
Then you can run the pull request via bin/solaar.

@mschilli87
Copy link
Contributor

@pfps: I think it would be good to include additional tags for affected devices (or device categories). For example, I wouldn't mind testing the occasional PR that modifies something w.r.t. my Logitech mouse, but having to read all PRs just to find that they affect keyboards only (which I do not own a Solaar-compatible model) would feel like a waste of my time.

In general, I think this repository would benefit from all devices, all keyboards, all mice, model foo, model bar, etc. tags on issues and PRs as many users are likely affected by only a smaller part of the codebase.

@pfps
Copy link
Collaborator

pfps commented Jul 1, 2020

I'll see what I can do. I have been trying to add comments on who should test PRs so you only have to look at the messages about PRs to see what you can test.

@pwr-Solaar pwr-Solaar deleted a comment from FFY00 Mar 12, 2021
@pwr-Solaar pwr-Solaar deleted a comment from FFY00 Mar 12, 2021
@pwr-Solaar pwr-Solaar deleted a comment from heynnema Mar 12, 2021
@pwr-Solaar pwr-Solaar deleted a comment from FFY00 Mar 12, 2021
@pfps pfps closed this as completed Nov 23, 2021
@pfps pfps unpinned this issue Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants