Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device switch from initialization to reconstruct #643

Open
erh3cq opened this issue Apr 3, 2024 · 0 comments
Open

Device switch from initialization to reconstruct #643

erh3cq opened this issue Apr 3, 2024 · 0 comments
Assignees

Comments

@erh3cq
Copy link

erh3cq commented Apr 3, 2024

Problem:
There are issues with cupy's/numba's JIT compilers. They simply are not robust and there are issues with version matching. When initializing a phase object with device='gpu' a JIT compile error can occur (e.g. in py4DSTEM.process.phase.Parallax(...). If the initialization is done with device='cpu' to avoid the error, then the later reconstruction step (e.g. parallax_recon.reconstruct(...)) also need to be run in device='cpu' as currently implemented.

Solution
Allow for device transfer...or figure out a way to handle the cupy shenanigans.
@gvarnavi suggested the first one as cupy is ultimately out of our hands.

@gvarnavi gvarnavi self-assigned this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants