Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] What do we want to see in this package? #3

Open
20 tasks
Batalex opened this issue Aug 19, 2023 · 3 comments
Open
20 tasks

[META] What do we want to see in this package? #3

Batalex opened this issue Aug 19, 2023 · 3 comments

Comments

@Batalex
Copy link

Batalex commented Aug 19, 2023

Here are a few suggestions, doubling as a tracker for the implementation of said features.

Tracker

Code structure & content

Documentation

  • Badges
  • "Written" documentation
  • API reference
  • Publishing

Code quality

Collaboration

  • Licensing
  • CoC
  • Contributing guide

Packaging

  • Versionning
  • Building
  • Publishing

Automation

Implementations

Based on the pyOpenSci packaging guide, here are a few implementation suggestions

Code structure & content

  • src versus flat layout: src
  • File format configuration (e.g. .editorconfig):
root = true

[*]
end_of_line = lf
insert_final_newline = true
charset = utf-8
trim_trailing_whitespace = true

[*.py]
indent_style = space
indent_size = 4

[*.md]
trim_trailing_whitespace = false

Documentation

  • Badges
  • "Written" documentation: Sphinx
  • API reference: apidoc
  • Publishing: GH pages

Code quality

  • Formatter: Black
  • Linter(s): Ruff 👼
  • Type checker: mypy
  • Tests: pytest, coverage.py

Collaboration

  • Licensing: MIT, BSD3?
  • CoC
  • Contributing guide

Packaging

  • Versionning
  • Building: PDM
  • Publishing: PyPI, conda-forge, both?

Automation

  • Setting up CI: GH actions
  • Running everything locally: tox, nox, PDM?

Feel free to comment / change items 🐈‍⬛

@lwasser
Copy link
Member

lwasser commented Jun 24, 2024

Ok i'm finally carving out time to work on this with our workshop coming up!! thank you for this super detailed issue @Batalex - i'm sorry it has taken me so long to get to it! i'm going to work on some of this - this week!!

i'll open pr's for review

@lwasser
Copy link
Member

lwasser commented Jun 24, 2024

@all-contributors please add @Batalex for review

Copy link
Contributor

@lwasser

I've put up a pull request to add @Batalex! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants