Implementing Property Based Tesing using Hypothesis #4724
Conversation
|
@RohitP2005 Add Here: Line 100 in 421784e |
| @@ -267,8 +271,9 @@ def test_r_average(self): | |||
| assert pybamm.r_average(a + b) == pybamm.r_average(a) + pybamm.r_average(b) | |||
| assert pybamm.r_average(a - b) == pybamm.r_average(a) - pybamm.r_average(b) | |||
|
|
|||
| def test_yz_average(self): | |||
| a = pybamm.Scalar(1) | |||
| @given(st.integers(min_value=-(2**63), max_value=2**63 - 1)) | |||
There was a problem hiding this comment.
explained here at #4724 (comment)
|
Also, fix the PR heading. It's not proper. |
RohitP2005
requested review from
martinjrobins,
Saransh-cpp,
agriyakhetarpal,
kratman and
arjxn-py
as code owners
RohitP2005
changed the title
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
@prady0t |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4724 +/- ##
===========================================
- Coverage 99.22% 99.22% -0.01%
===========================================
Files 303 303
Lines 23070 23101 +31
===========================================
+ Hits 22891 22921 +30
- Misses 179 180 +1 ☔ View full report in Codecov by Sentry. |
| @@ -174,9 +177,10 @@ def test_x_average(self): | |||
| assert pybamm.x_average(a + b) == pybamm.x_average(a) + pybamm.x_average(b) | |||
| assert pybamm.x_average(a - b) == pybamm.x_average(a) - pybamm.x_average(b) | |||
|
|
|||
| def test_size_average(self): | |||
| @given(st.integers(min_value=-(2**63), max_value=2**63 - 1)) | |||
There was a problem hiding this comment.
I see. Having large-sized integers causes buffer overflow (probably because of different ways int is handled by pybamm and numpy ). Yes it's good to restrict the range here.
| random_value=st.integers(), | ||
| random_matrix=st.lists( | ||
| st.floats(min_value=-10, max_value=10), min_size=5, max_size=5 | ||
| ), |
There was a problem hiding this comment.
Can we increase the size here? i'll look into this bit later
There was a problem hiding this comment.
okay , i guess 10 will be good a number
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
Co-authored-by: Pradyot Ranjan <[email protected]>
|
@RohitP2005 you keep merging develop into this branch, but there are still a bunch of failing tests. Can you fix those so the review can continue |
Sorry about that, my previous commit passed the CI test, after the new branch merge it is failing. I will look into it asap. |
Description
This change introduces the use of Hypothesis-based testing in two files and is being applied to selective functions as requested by the author and members of the issue #4703 (comment)
Fixes #4703
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python -m pytest(or$ nox -s tests)$ python -m pytest --doctest-plus src(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks: