Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] build-each-commit.py script hard-codes master branch as base #2041

Open
dlech opened this issue Feb 1, 2025 · 0 comments
Open

[Bug] build-each-commit.py script hard-codes master branch as base #2041

dlech opened this issue Feb 1, 2025 · 0 comments
Labels
bug Something isn't working devops Issues related to continuous integration and distribution of software. software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime)

Comments

@dlech
Copy link
Member

dlech commented Feb 1, 2025

Describe the bug
CI builds targeting the pybricks-v4.x branch are really slowed down because the build-each-commit.py script hard-codes the master branch as the base branch.

https://github.com/pybricks/pybricks-micropython/blob/77384ec20b25115d622fa654505ced9e2e3bc4ed/.github/build-each-commit.py#L45

To reproduce

Run a CI build like: https://github.com/pybricks/pybricks-micropython/actions/runs/13093071041/job/36532011230

Expected behavior
We should only build each commit from the pull request compared to the base branch of the pull request.

Alternative
We can use the master branch for more experimental stuff and start a new branch for the next release.

@dlech dlech added bug Something isn't working devops Issues related to continuous integration and distribution of software. software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devops Issues related to continuous integration and distribution of software. software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime)
Projects
None yet
Development

No branches or pull requests

1 participant