Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve QR Move SCP #489

Open
scaramallion opened this issue May 22, 2020 · 1 comment
Open

Improve QR Move SCP #489

scaramallion opened this issue May 22, 2020 · 1 comment

Comments

@scaramallion
Copy link
Member

scaramallion commented May 22, 2020

The interface for the QR Move SCP could use some work:

  • The code itself is fairly spaghettied (as is Get) which makes changes harder than they should be
  • No simple way to set the configuration of the association with the move destination (particularly the presentation contexts)
  • All the transfers happen over the same association which means hitting the limitations of the DICOM presentation contexts negotiation system
    • This last one depends on the user, but maybe we can track the number of contexts that have been used and if > 128 restart the Storage SCU connection?
    • Alternatively provide a method for the user to restart the Storage SCU connection
@scaramallion scaramallion added this to the v2.0.0 milestone May 22, 2020
@scaramallion
Copy link
Member Author

scaramallion commented May 23, 2020

Possibilities...

  1. When yielding the (address, port) of the Move Destination allow the user to optionally yield kwargs to pass AE.associate(). This seems like the simplest option to control the presentation contexts and is relatively simple to implement so it could be done in v1.5
  2. Add a new event evt.EVT_C_MOVE_ASSOC, although I don't think it'll be flexible enough

The form:

try:
     something()
except Exception as exc:
    logger.error('some failure str')
    logger.exception(exc)
    rsp.Status = 0xC514
    self.dimse.send_msg(rsp, context.context_id)
    return

is also used a lot, maybe we can replace it with a context instead?

with attempt(msg='some failure str', status=0xC514):
    something()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant