Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python2 generator work around #7659

Open
wd60622 opened this issue Jan 25, 2025 · 3 comments · May be fixed by #7664
Open

Remove Python2 generator work around #7659

wd60622 opened this issue Jan 25, 2025 · 3 comments · May be fixed by #7664

Comments

@wd60622
Copy link
Contributor

wd60622 commented Jan 25, 2025

Seems stale:

pymc/pymc/data.py

Lines 111 to 121 in b36e573

def __next__(self):
"""Next value in the generator."""
if not self._yielded_test_value:
self._yielded_test_value = True
return self.test_value
else:
return smarttypeX(copy(next(self.gen)))
# python2 generator
next = __next__

@ricardoV94
Copy link
Member

That whole thing is deprecated (if you trigger it via the user-facing API)

@wd60622
Copy link
Contributor Author

wd60622 commented Jan 25, 2025 •
edited
Loading

I see the deprecation warning dating to August. Can I do the honors of removing?

@ricardoV94
Copy link
Member

Sure

@wd60622 wd60622 linked a pull request Jan 29, 2025 that will close this issue
Draft
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated generator data wd60622/pymc
2 participants
@ricardoV94 @wd60622