Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test files unvendoring functionality #41

Open
agriyakhetarpal opened this issue Jan 23, 2025 · 2 comments
Open

Add test files unvendoring functionality #41

agriyakhetarpal opened this issue Jan 23, 2025 · 2 comments

Comments

@agriyakhetarpal
Copy link
Member

Recently, I provided pyodide-build's unvendor_tests() functionality as a separate unvendor_tests_from_wheel.py CLI script as a part of sympy/live#26, to reduce the size of the SymPy wheel downloaded from PyPI.

Would it be a good idea for pyodide-pack to include such functionality as well, so that it can be used as a CLI tool for downstream projects like this?

As a further step, would it make sense to remove this functionality from pyodide-build, and make it call pyodide-pack as a part of the wheel build process in https://github.com/pyodide/pyodide-recipes?

@ryanking13
Copy link
Member

Thanks for the proposal @agriyakhetarpal!

I made a similar issue in the pyodide-lock repository: pyodide/pyodide-lock#30, because I thought the test unvendoring feature was related to the lockfile.

But if you think it can be used not only in the lockfile, but also in general purpose (reducing the size of the wheel file), I think it is a good idea to put it under pyodide-pack as pyodide-pack is designed for various optimizations.

We've considered moving the pyodide py-compile CLI to pyodide-pack as well.

@ryanking13
Copy link
Member

This issue is also worth reading: pyodide/pyodide#3092. Of course, this is a separate discussion from moving the test unvendoring feature, but it would be helpful to be able to generalize the "unvendoring" in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants