You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would it be a good idea for pyodide-pack to include such functionality as well, so that it can be used as a CLI tool for downstream projects like this?
As a further step, would it make sense to remove this functionality from pyodide-build, and make it call pyodide-pack as a part of the wheel build process in https://github.com/pyodide/pyodide-recipes?
The text was updated successfully, but these errors were encountered:
I made a similar issue in the pyodide-lock repository: pyodide/pyodide-lock#30, because I thought the test unvendoring feature was related to the lockfile.
But if you think it can be used not only in the lockfile, but also in general purpose (reducing the size of the wheel file), I think it is a good idea to put it under pyodide-pack as pyodide-pack is designed for various optimizations.
We've considered moving the pyodide py-compile CLI to pyodide-pack as well.
This issue is also worth reading: pyodide/pyodide#3092. Of course, this is a separate discussion from moving the test unvendoring feature, but it would be helpful to be able to generalize the "unvendoring" in the future.
Recently, I provided
pyodide-build
'sunvendor_tests()
functionality as a separateunvendor_tests_from_wheel.py
CLI script as a part of sympy/live#26, to reduce the size of the SymPy wheel downloaded from PyPI.Would it be a good idea for
pyodide-pack
to include such functionality as well, so that it can be used as a CLI tool for downstream projects like this?As a further step, would it make sense to remove this functionality from
pyodide-build
, and make it callpyodide-pack
as a part of the wheel build process in https://github.com/pyodide/pyodide-recipes?The text was updated successfully, but these errors were encountered: