Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyupgrade/black/isort/flake8 → ruff #765

Closed
DimitriPapadopoulos opened this issue Jan 5, 2024 · 2 comments · Fixed by #769
Closed

pyupgrade/black/isort/flake8 → ruff #765

DimitriPapadopoulos opened this issue Jan 5, 2024 · 2 comments · Fixed by #769
Labels
infrastructure

Comments

@DimitriPapadopoulos
Copy link
Contributor

This is a suggestion to move from the tools listed in .pre-commit-config.yaml to ruff.

The rationale:

  • Ruff is gaining momentum, at least in scientific Python packages, enough to appear as a stable tool available in the long term.
  • Simplify by using a single tool to lint and format.
  • More ruff rules could be added, specifically flake8-bugbear.
@brettcannon
Copy link
Member

I'm supportive of switching if @pradyunsg is.

@DimitriPapadopoulos DimitriPapadopoulos mentioned this issue Jan 8, 2024
Merged
@DimitriPapadopoulos
Copy link
Contributor Author

See what it would look like in #769.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pyupgrade/black/isort/flake8 → ruff DimitriPapadopoulos/packaging
2 participants
@brettcannon @DimitriPapadopoulos