Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutting a new release #1585

Closed
pganssle opened this issue Nov 11, 2018 · 2 comments
Closed

Cutting a new release #1585

pganssle opened this issue Nov 11, 2018 · 2 comments
Labels
Needs Discussion Issues where the implementation still needs to be discussed. question

Comments

@pganssle
Copy link
Member

I would like to cut a new release on Monday or Tuesday, preferably one that will include #1576.

I think most changes in the changelog are backwards-compatible, so we could do 40.5.0, but depending on your view, #1554 or #1545 may be considered backwards-incompatible. I'd also like to get #1559 merged, and I consider that a bugfix, but it's possible that people might consider it backwards incompatible. Anyone have thoughts on whether we should do 40.5.0 or 41.0.0?

Also, is there anything that anyone wants to get prioritized for inclusion in the next release?

@pganssle pganssle added question Needs Discussion Issues where the implementation still needs to be discussed. labels Nov 11, 2018
@jaraco
Copy link
Member

jaraco commented Nov 11, 2018

I agree that some of those do seem like they could cause incompatibilities. My rule of thumb on when to bump the major version is if the incompatibility is likely to require user intervention to accommodate the change, it should have a major bump and the changelog should describe what intervention is expected. If the likelihood of intervention is negligible, then no docs are needed and no major bump is indicated.

I think #1559 in particular qualifies as backward-incompatible.

@pganssle
Copy link
Member Author

I think I will cut a 40.5.0 first, since #1559 is not merged yet. For the record I agree whole-heartedly with that version scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion Issues where the implementation still needs to be discussed. question
Projects
None yet
Development

No branches or pull requests

2 participants