Fix handling of continuation lines in Description metadata field #1220
+83
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnicolodi
force-pushed
the
fix-description-continuation
branch
from
c9741b8 to
a80bd00
Compare
dnicolodi
force-pushed
the
fix-description-continuation
branch
from
a80bd00 to
ecf7e91
Compare
sigmavirus24
requested changes
Jan 23, 2025
Comment on lines
+81
to
+82
| or all(line.startswith(" |") for line in lines[1:]) | ||
| or all(line.startswith(" ") for line in lines[1:]) |
There was a problem hiding this comment.
Suggested change
| or all(line.startswith(" |") for line in lines[1:]) | |
| or all(line.startswith(" ") for line in lines[1:]) | |
| or all(line.startswith((" |", " ")) for line in lines[1:]) |
There was a problem hiding this comment.
This would implement a different check. The code as written tests whether all the line start with 8 spacer or all the lines start with 7 spaced and a pipe. The proposed code tests with all the lines start with either 8 spaces or 7 spaces and a pipe. I don't think we should treat intermixed continuation style as valid. There is a test that ensures that someone else is not tempted into the same erroneous simplification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1218.