Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twine check should catch quotes in URLs #701

Closed
henryiii opened this issue Sep 30, 2020 · 2 comments
Closed

twine check should catch quotes in URLs #701

henryiii opened this issue Sep 30, 2020 · 2 comments
Labels
duplicate enhancement

Comments

@henryiii
Copy link
Contributor

henryiii commented Sep 30, 2020 •
edited
Loading

Currently, twine check doesn't catch this in a setup.cfg file:

url = "https://github.com/pybind/pybind11"

which creates this in pybind11-2.6.0b1.dist-info/METADATA:

Home-page: "https://github.com/pybind/pybind11"

which fails to upload to PyPI.

HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
24
'"https://github.com/pybind/pybind11"' is an invalid value for Home-Page. Error: Invalid URI See https://packaging.python.org/specifications/core-metadata for more information.
@sigmavirus24
Copy link
Member

Yeah, that makes sense. It's not terribly hard to do either.

@bhrutledge
Copy link
Contributor

This feels like a duplicate of #430, along with #589, which is currently blocked by pypa/packaging#147.

I've started keeping track of all of these related issues in https://github.com/pypa/twine/projects/2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sigmavirus24 @bhrutledge @henryiii