Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing pyrra_availability for latencyNative SLO #1418

Open
samwright opened this issue Feb 24, 2025 · 0 comments
Open

Missing pyrra_availability for latencyNative SLO #1418

samwright opened this issue Feb 24, 2025 · 0 comments

Comments

@samwright
Copy link

The latencyNative SLO indicator currently doesn't support generic/grafana rules. I've created a PR adding support for the pyrra_availability metric. It's a small change, guided by the grafana docs on using native histograms.

I haven't added the pyrra_errors_total or pyrra_requests_total rules because I don't think it is possible to generate a counter metric like those from a native histogram. The histogram contains values that act as counter metrics, which must go through a function like rate to be converted to values that act as a gauge metrics, and only then can the histogram_* functions be called on them. I think the best we can do is create a new gauge metric representing the requests + errors in the last e.g. 30s. This is annoying when creating grafana graphs, as zooming out means you might miss a peak...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant