Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: apexpy not routinely tested #126

Open
jklenzing opened this issue Jan 2, 2025 · 0 comments
Open

BUG: apexpy not routinely tested #126

jklenzing opened this issue Jan 2, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@jklenzing
Copy link
Member

Description

The main.yml workflow currently never attempts to install apexpy. Current configs are set toif: ${{ matrix.numpy_ver != 'latest' && matrix.os == 'macos-latest' }} and if: ${{ matrix.numpy_ver != 'latest' && matrix.os != 'macos-latest' }}, which are never True because only ubuntu is tested for older numpy versions.

With the fixes in apexpy 2.1.0, we can reconfigure based on the external_rc workflow so that it always tries to install. The continue_on_error setting can still be True since these are optional installs.

To Reproduce this bug:

Inspect the main.yml workflow results.

Test configuration

GitHub Actions main.yml

Additional context

aacgmv2 is now working regularly with the latest release. We should update apexpy tests as well.

@jklenzing jklenzing added the bug Something isn't working label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant