Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Advent of Code Features #6

Open
janine9vn opened this issue Feb 22, 2022 · 2 comments
Open

Migrate Advent of Code Features #6

janine9vn opened this issue Feb 22, 2022 · 2 comments
Assignees
@D0rs4n
Labels
Area: Advent of code Ready for Implementation Proposed approach/implementation is solid, let's implement this thing

Comments

@janine9vn
Copy link
Collaborator

This is going to remove Advent of Code features from Sir Lancebot and add them here. This will have to wait until #4 is complete.

Important Notes

  • Advent of Code was hero-sprinted originally, so there are a few ... bugs in it. If someone would like to do a straight feature port and only do the disnake conversions, that's fine. However, someone kaizening these features would also be fine with me. The lionshare of updates and improvements thought should be saved for a later PR date.
  • This feature port will be rougher than others due to the season-locks it's assuming we'll have. I do not want season locks in Sir Robin. So we need to think of another solution.
@janine9vn janine9vn added the Stalled Feature is stalled due to external reasons label Feb 22, 2022
@D0rs4n
Copy link
Member

D0rs4n commented Feb 22, 2022

I'd be interested in the migration, have worked with the AoC features on AoC previously.
(At least I'll try to get it done 👍 )

@D0rs4n D0rs4n self-assigned this Feb 22, 2022
@ToxicKidz ToxicKidz added Ready for Implementation Proposed approach/implementation is solid, let's implement this thing and removed Stalled Feature is stalled due to external reasons labels Feb 26, 2022
@D0rs4n D0rs4n mentioned this issue Mar 6, 2022
Closed
@janine9vn
Copy link
Collaborator Author

#66 Partially handles this, but it also ports the seasonal-locks as is, which I dislike.
I'll keep this issue open for now until I can create proper issues for the other changes I'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@D0rs4n D0rs4n

Labels
Area: Advent of code Ready for Implementation Proposed approach/implementation is solid, let's implement this thing
Projects
None yet
Milestone
No milestone
3 participants
@janine9vn @D0rs4n @ToxicKidz