Add platform (arch) for ExecuTorch dashboard #6234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
guangy10
approved these changes
Jan 31, 2025
I'm okay with pagination. If users have specific preference we can make a request for it later. To me, as a users, I think I can efficiently zoom in to the model/backend/platform that I want to take a close look from the main page |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address part of pytorch/executorch#7986
The historical context here is that the older schema for benchmark database didn't have a separate columns for
device, i.e.cpu, andarch, i.e.x86_64. So, they are bundle together into a single one calleddeviceArch.This PR splits this field into
deviceandarchfield behind the scene, but keeps the display name in the same format, i.e.Apple iPhone 15 (iOS 18.0)to maintain the same UX, which allows me to add a new platform (arch) dropdown list for ExecuTorch. The list has only 3 optionsAndroidandiOSandAll Platforms,and only one can be selected at a time (this is the part that fixes pytorch/executorch#7986)This also applies lint to these queries and fixes a bug in which sqlfluff doesn't recognize the configuration file at
.sqlfluffI found that https://mui.com/x/react-data-grid/pagination/ only allows up to 100 rows before enforcing pagination. Having more requires the paid pro version.
Testing
https://torchci-git-fork-huydhn-tweak-et-dashboard-fbopensource.vercel.app/benchmark/llms?repoName=pytorch%2Fexecutorch shows a new platform dropdown list