Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The theme hides links to notebook in the sphinx-gallery examples #125

Open
NicolasHug opened this issue May 14, 2021 · 0 comments
Open

The theme hides links to notebook in the sphinx-gallery examples #125

NicolasHug opened this issue May 14, 2021 · 0 comments

Comments

@NicolasHug
Copy link
Member

NicolasHug commented May 14, 2021

We have recently introduced a gallery of examples from sphinx-gallery in the torchvision docs

Normally, there should be a link on every example saying "Download Jupyter notebook:..." which is automatically generated by sphinx-gallery.

Unfortunately the pytorch_sphinx_theme seems to re-style those links with custom code but this only works for the tutorial repo. In the other repos, the links are deactivated: you can see that there's no link in this example, yet the html code exists, it's just being hidden by some CSS.

I believe that the offending lines are these

article.pytorch-article .sphx-glr-download-link-note.admonition.note,

with possibly these ones too:

// This code replaces the default sphinx gallery download buttons

and

https://github.com/pytorch/pytorch_sphinx_theme/blob/master/pytorch_sphinx_theme/layout.html#L275

Unfortunately my web dev skills are very weak so I'm unable to address this myself, but it would be very valuable to our users to have those links to the notebooks in the examples.

CC @brianjo @holly1238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant