Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections and improvements to README.md #1

Open
mouradvt04 opened this issue Oct 19, 2021 · 0 comments
Open

Corrections and improvements to README.md #1

mouradvt04 opened this issue Oct 19, 2021 · 0 comments

Comments

@mouradvt04
Copy link

Few comments:

  1. Add a short explanation on how to create matches_csv_file_name from the files (train, test, valid) that are in https://github.com/anhaidgroup/deepmatcher/blob/master/Datasets.md, concat all, keep line with label "1", and remove last column "label"

  2. Correct vector_pairing_model --> topK_vector_pairing_model or vice-versa

  3. Add line for cols_to_block = ["title","manufacturer","price"] with short explanation

  4. Mention that configuration should be checked and that the embeddings file obtained from https://fasttext.cc/docs/en/pretrained-vectors.html is already in the correct folder

  5. In the readme file, put "installation" before the 30 sec section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant