-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update installation section #988
Comments
In principle, for a vanilla installation, you should just run However, I acknowledge that with drivers is more complicated, because of |
For sure the part where you need to select the corresponding drivers is not trivial, many people that were starting face problems because of this. |
Well, we could have a
and nothing else (until when we'll support external drivers, in which case you could list further packages in there). However, environments are tricky beasts, so I'd avoid automating too much, to avoid automatic breaking... |
I'm not certain about this. With your proposal, we will end up with duplicated information, with just minor changes. |
I thought you misunderstood my proposal. I'm not suggesting to duplicate any information, but just to list the suitable qibolab extras in each platform.
This is not something you can list in the general instructions. Unless you instruct the user to always install all possible extra dependencies, whatever platform you want to use. (I.e. given Qibocal docs, and the platform files, how do you know which are the So, the README section I have in mind is: ## Qibolab extras
This platform requires `qm` and `twpas` extra. or as a bulleted list, if you prefer. In principle, you could even replace it by: ## Dependencies installation
```sh
pip install qibolab[qm, twpas]
``` which would duplicate the In any case, in the general instructions, you would add a "read the platform" comment, and possibly an explanation. But this should be done in Qibolab, and just linked in Qibocal.
Here I may be the one not understanding, since I can't make sense of this part. If you don't need to use a platform, you don't need to clone the platforms' repo (nor manually copy, fwiw...). But then all you need is All the problem arises because you actually want to use a platform, and since you're not writing it (otherwise you'd read the Qibolab docs, and possibly understand the role of extra dependencies - assuming we wrote it there) you definitely need to take it from somewhere. I.e. you either clone or navigate. P.S.: by platforms' |
My only worry with this approach is that if you do naively |
That's why I was proposing to install first Qibolab, then Qibocal. Or the two of them in the same command, in case
Yes, this is what I had in mind since the beginning. I'm not sure it's even possible - because extras could group existing dependencies, but you should not be able to have different versions of the same, including different combinations of its extras. But even if it is, I'm pretty sure I'd like to avoid... The other option could be to first install Qibocal, work out which is the installed Qibolab version, and then install Qibolab specifying both the extras and the same version is already installed, like: pip install qibocal
# find out qibolab installed version, x.y.z
pip list | grep qibolab
# fix qibolab version to x.y.z
pip install qibolab[ex,tra,s,...]==x.y.z But it's definitely more cumbersome... |
Thanks @alecandido, now your idea is clear and I agree. |
Add a section to the documentation that explains how to install Qibo-cal and -lab with the drivers, specifying the compatible Qibolab version.
This section should be helpful for new joiners, as we have observed that the installation procedure is not always smooth and well-documented.
The text was updated successfully, but these errors were encountered: