-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Specification for the Adaptive Profile #35
Adding Specification for the Adaptive Profile #35
Conversation
…fixed point numbers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was asked to take a look, so here are some quick comments. I'll come back later when I have time.
One question I couldn't find a suitable place for based on a quick search is a way for backends to specify whether they want their loops unrolled (if possible) or not.
…d on last week's discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gotten as far as the Program Structure section. This is well written, but it's taking me a while to work through it!!
I'll come back later. 😓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that isn't clear from reading, and it seems this context also switches depending upon topic, is whether the spec views QIR to be run almost-directly on a QPU, or whether it's executed by a runtime which provides classical support and that calls to a QPU.
It talks about classical results post-processing on one hand, then about how memory on the FPGA should be highlighted to consumer systems on the other. I've always considered it (relatively) high-level - your QIR is the basic outline of what you'd like to run, including all contextual information added to help the backend run your request better. Especially since if you implement the full QIR spec you can send classical programs with fragments of quantum in it and run them directly.
While you can interpret it at both levels, and it depends upon what sort of backend you have, certain assertions and constraints don't apply depending upon what lens you look at it though.
Also out of curiosity: is this the outcome of some working group?
…rguments, and the connection of module flags to output recording functions
This VSCode extension is amazing: https://marketplace.visualstudio.com/items?itemName=TakumiI.markdowntable
Fix issues reported my markdownlint, typos
CLA Assistant Lite bot: I have read the Contributor License Agreement and I hereby accept the Terms. 3 out of 4 committers have signed the CLA. |
Revision for clarity and distinction of two kinds of loops
…ints is described in writing about module flags, and remove %Result from a return type for IR-defined functions and make it so that it must be a standard classical type from the extension
I have a PR at peter-campora#5 that should resolve the cspell issue and some formatting. There is a FIXME comment that still remains. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on behalf of the steering committee. This was officially voted on and approved for merge. Any minor fixes that do not change the technical intend (such as spelling, formatting, etc.) can be fixed if needed with PRs directly on the spec repo without a full process/vote of the SC.
@qartik Please direct any PRs to fix spelling or formatting directly to the main branch of the qir-spec repo. |
Trying this again. I expect linting issues but hopefully no committer/CLA issues. Initial draft of the specification here for public comments.