Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildNumber is not propagated in dev mode #457

Open
rsvoboda opened this issue Jun 19, 2024 · 1 comment
Open

buildNumber is not propagated in dev mode #457

rsvoboda opened this issue Jun 19, 2024 · 1 comment

Comments

@rsvoboda
Copy link
Member

buildNumber is not propagated in dev mode and DEV UI shows app version as null in the top right corner of http://localhost:8080/q/dev-ui/ and in http://localhost:8080/q/dev-ui/welcome
Screenshot 2024-06-19 at 14 39 31

This behaviour is caused by #231 changes which sets the version based on the hash, buildNumber property is set to null in dev mode:
Screenshot 2024-06-19 at 14 24 56

Hash works fine when running app in JVM production mode, here is the message from dev mode vs. production jvm mode:

2024-06-19 14:23:01,533 INFO  [io.quarkus] (Quarkus Main Thread) quarkus-bot on JVM (powered by Quarkus 3.11.2) started in 1.267s. Listening on: http://localhost:8080
    vs.
2024-06-19 14:30:02,608 INFO  [io.quarkus] (main) quarkus-bot 77f2357 on JVM (powered by Quarkus 3.11.2) started in 0.499s. Listening on: http://0.0.0.0:8080

I tried to propagate revision property same way as in 88d76b2 and expected value was visible in configuration editor.

Seems this all goes to buildnumber-maven-plugin and how it sets the buildNumber property. @gastaldi any tips on this?

@gastaldi
Copy link
Contributor

gastaldi commented Jul 15, 2024

That doesn't seem to be propagated from a ConfigSource during dev mode. As a workaround, you can do the same as I did in registry.quarkus.io: add buildNumber=999-SNAPSHOT to your local .env, which will display the version as 999-SNAPSHOT when in dev mode/tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants