New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update or delete UserViewModelProtocol #84

Open

BK-Teisrud opened this issue Jul 6, 2021 · 0 comments

Labels

cleaner code improvement

Collaborator

BK-Teisrud commented Jul 6, 2021

In the current implementation of the application, all ViewModels are based on UserViewModelProtocol.

UserViewModel.swift contains only one method. It is the reset method.

protocol UserViewModelProtocol: ObservableObject{
    //var user: User {get set}
    func reset()
}

In all ViewModels (UserViewModel, StudentViewModel, TeacherViewModel and AdminViewModel), the reset method is implemented as an empty method.

func reset() {
        
}

We need to update UserViewModelProtocol.swift or just remove it completely. It is of no use as it is implemented today

BK-Teisrud added cleaner code improvement labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment