Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve enforcement of SSL for dbConnect() and the output when printing connections #328

Merged
merged 12 commits into from
Apr 14, 2024

Conversation

d-hansen
Copy link
Contributor

@d-hansen d-hansen commented Apr 1, 2024

  • Removed unnecessary casting in mysql_options (do not need to explicitly cast to void *)
  • Remove long since deprecated and removed flag CLIENT_SECURE_CONNECTION
  • Added CLIENT_SSL_VERIFY_SERVER_CERT
  • Added some documentation about using SSL with the client.flag including CLIENT_SSL.
  • Cleaned up and added information to show output for a DB Connection. Output now looks something like:
<MySQLConnection>
  Hostname:       my-database-1.xyzzy.us-east-1.rds.amazonaws.com
  Username:       r_user
  Database:       r_test_db
  Server Port:    3306
  Connection:     my-database-1.xyzzy.us-east-1.rds.amazonaws.com via TCP/IP
  Protocol:       10
  SSL Cipher:     ECDHE-RSA-AES128-GCM-SHA256
  Thread Id:      10615
  Client Version: 5.7.44
  Client Flags:   01BEAA8D
  Server Version: 8.0.35
  Capabilities:   DFFFFFFF
  SQL Status:     00000000

Copy link
Contributor

aviator-app bot commented Apr 1, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link
Member

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

R/connect.R Show resolved Hide resolved
R/show_MariaDBConnection.R Outdated Show resolved Hide resolved
@d-hansen
Copy link
Contributor Author

Not sure what was the problem with the macos build trying to get R... Probably the R feed was getting updated and temporarily unavailable.

@krlmlr krlmlr changed the title improve dbConnect() SSL feat: Improve enforcement of SSL for dbConnect() and the output when printing connections Apr 14, 2024
@krlmlr
Copy link
Member

krlmlr commented Apr 14, 2024

Thanks!

@aviator-app aviator-app bot added the blocked label Apr 14, 2024
Copy link
Contributor

aviator-app bot commented Apr 14, 2024

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Once the issues are resolved, remove the blocked label and re-queue the pull request. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).

@krlmlr krlmlr merged commit 44b0ec2 into r-dbi:main Apr 14, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants