-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add back SSL support for MariaDB 5.5.68 #338
Conversation
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
Thanks for the super-quick fix. How can we test this in CI/CD? |
mariadb-libs-5.5.68 is still generally available: https://rpmfind.net/linux/RPM/centos/7.9.2009/x86_64/Packages/mariadb-libs-5.5.68-1.el7.x86_64.html |
FYI: this archive includes the -devel package: |
Well, I see you run Ubuntu 22.04. So, here is a link you can download MariaDb 5.5.68 for a systemd-based Linux: |
Thanks. I want to add old MariaDB to CI/CD before merging this. @BillWeld: Can you please confirm that this PR works for you? |
I don’t know how to grab that version. I can specify releases by git tag if there’s a tag you can point me to.
… On Jul 1, 2024, at 4:50 PM, Kirill Müller ***@***.***> wrote:
Thanks. I want to add old MariaDB to CI/CD before merging this.
@BillWeld <https://github.com/BillWeld>: Can you please confirm that this PR works for you?
—
Reply to this email directly, view it on GitHub <#338 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACUGAOFO6W4YTKPIYAMLXTTZKG6LBAVCNFSM6AAAAABKGE4EFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQHE4TOMZYHE>.
You are receiving this because you were mentioned.
|
@BillWeld: Can you please install_github("r-dbi/RMariaDB#338") or install_github("d-hansen/RMariaDB") ? |
Will do. On Jul 7, 2024, at 4:22 PM, Kirill Müller ***@***.***> wrote:
@BillWeld: Can you please
install_github("r-dbi/RMariaDB#338")
or
install_github("d-hansen/RMariaDB")
?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Both build cleanly.
Thanks,
Rob
… On Jul 7, 2024, at 4:22 PM, Kirill Müller ***@***.***> wrote:
@BillWeld <https://github.com/BillWeld>: Can you please
install_github("r-dbi/RMariaDB#338")
or
install_github("d-hansen/RMariaDB")
?
—
Reply to this email directly, view it on GitHub <#338 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACUGAOBHXEDKI6CO6FO6XG3ZLGPPFAVCNFSM6AAAAABKGE4EFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGU3DANBUG4>.
You are receiving this because you were mentioned.
|
Hey, I noticed this PR is still outstanding. Any update on merging it? Anything you need from me? |
Thanks. Taking care of the failing builds in #344. |
… MariaDB version in AWS AL2 base. Note: AWS AL2 will be deprecated and replaced by AL2023 in June 2025.
Thanks, also for the nudge! |
Add back SSL support for MariaDb 5.5.68 which seems to be the default MariaDB version in AWS AL2 base.
Note: AWS AL2 will be deprecated and replaced by AL2023 in June 2025.
Note2: At some point in the future, I would expect some version of MariaDB (> 11) to follow suit with MySQL 8 and switch to using the
MYSQL_OPT_SSL_MODE
instead ofMYSQL_OPT_SSL_ENFORCE
to enable SSL.Closes #336.