Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add back SSL support for MariaDB 5.5.68 #338

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

d-hansen
Copy link
Contributor

@d-hansen d-hansen commented Jul 1, 2024

Add back SSL support for MariaDb 5.5.68 which seems to be the default MariaDB version in AWS AL2 base.

Note: AWS AL2 will be deprecated and replaced by AL2023 in June 2025.
Note2: At some point in the future, I would expect some version of MariaDB (> 11) to follow suit with MySQL 8 and switch to using the MYSQL_OPT_SSL_MODE instead of MYSQL_OPT_SSL_ENFORCE to enable SSL.

Closes #336.

Copy link
Contributor

aviator-app bot commented Jul 1, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@krlmlr
Copy link
Member

krlmlr commented Jul 1, 2024

Thanks for the super-quick fix. How can we test this in CI/CD?

@d-hansen
Copy link
Contributor Author

d-hansen commented Jul 1, 2024

mariadb-libs-5.5.68 is still generally available: https://rpmfind.net/linux/RPM/centos/7.9.2009/x86_64/Packages/mariadb-libs-5.5.68-1.el7.x86_64.html
I'm not sure what system you are using to host your CI/CD, but probably just make an docker container that includes that version of the MariaDb libraries.

@d-hansen
Copy link
Contributor Author

d-hansen commented Jul 1, 2024

FYI: this archive includes the -devel package:
https://archive.mariadb.org/mariadb-5.5.68/yum/rhel/6Server/x86_64/rpms/

@d-hansen
Copy link
Contributor Author

d-hansen commented Jul 1, 2024

Well, I see you run Ubuntu 22.04. So, here is a link you can download MariaDb 5.5.68 for a systemd-based Linux:
https://archive.mariadb.org/mariadb-5.5.68/bintar-linux-systemd-x86_64/mariadb-5.5.68-linux-systemd-x86_64.tar.gz
That's the full server enchilada, so should be more than enough to test with.
Probably just make a copy of this environment "ubuntu-22.04 (release) MariaDB server + client" but use the above link for the install of MariaDB.

@krlmlr
Copy link
Member

krlmlr commented Jul 1, 2024

Thanks. I want to add old MariaDB to CI/CD before merging this.

@BillWeld: Can you please confirm that this PR works for you?

@BillWeld
Copy link

BillWeld commented Jul 2, 2024 via email

@krlmlr
Copy link
Member

krlmlr commented Jul 7, 2024

@BillWeld: Can you please

install_github("r-dbi/RMariaDB#338")

or

install_github("d-hansen/RMariaDB")

?

@BillWeld
Copy link

BillWeld commented Jul 7, 2024 via email

@BillWeld
Copy link

BillWeld commented Jul 8, 2024 via email

@d-hansen
Copy link
Contributor Author

Hey, I noticed this PR is still outstanding. Any update on merging it? Anything you need from me?

@krlmlr
Copy link
Member

krlmlr commented Aug 29, 2024

Thanks. Taking care of the failing builds in #344.

… MariaDB version in AWS AL2 base.

Note: AWS AL2 will be deprecated and replaced by AL2023 in June 2025.
@krlmlr krlmlr changed the title SSL support for MariaDb 5.5.68 feat: Add back SSL support for MariaDB 5.5.68 Sep 3, 2024
@krlmlr krlmlr merged commit 720dc7d into r-dbi:main Sep 3, 2024
24 checks passed
@krlmlr
Copy link
Member

krlmlr commented Sep 3, 2024

Thanks, also for the nudge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.3.2 build fails
3 participants