Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't read_txt_Shimadzu() be faster? #60

Open
GegznaV opened this issue Aug 6, 2021 · 4 comments
Open

Shouldn't read_txt_Shimadzu() be faster? #60

GegznaV opened this issue Aug 6, 2021 · 4 comments

Comments

@GegznaV
Copy link
Member

GegznaV commented Aug 6, 2021

On my machine, it takes arround 2 minutes to read GCxGC-qMS.txt file in read_txt_Shimadzu() unit test:

 system.time({
     filename <- system.file(
         "extdata",
         "txt.Shimadzu/GCxGC-qMS.txt",
         package = "hySpc.read.txt"
     )
     
     spc <- read_txt_Shimadzu(filename)
 })
#>   user  system elapsed 
#> 124.50   17.56  143.90 

143.90/60 ≈ 2.398 min

image

It is way too long.

Either the function is too slow or the file is too large. What should we do about this, @sangttruong, @bryanhanson, @cbeleites?
Should we skip this test for now?


Related:

@GegznaV
Copy link
Member Author

GegznaV commented Aug 6, 2021

This is a piece of RSudio profiling information:

image

The bottleneck seems to be here (49.4 is memory and 71540 is time usage):

image

@GegznaV
Copy link
Member Author

GegznaV commented Aug 6, 2021

image

image

@GegznaV
Copy link
Member Author

GegznaV commented Aug 6, 2021

The test file is large:
image

@GegznaV
Copy link
Member Author

GegznaV commented Aug 6, 2021

Can we have a smaller test file? @cbeleites

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant