Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vctrs_init_altrep_lazy_character function signatures consistent #1872

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

georgestagg
Copy link
Contributor

@georgestagg georgestagg commented Aug 16, 2023

In src/altrep-lazy-character.c we have,

void vctrs_init_altrep_lazy_character(DllInfo* dll) {
[...]
}

but in src/init.c we have,

extern r_obj* vctrs_init_altrep_lazy_character(DllInfo*);

This breaks vctrs 0.6.3 under webR because Wasm requires consistent function signatures across compilation units. The function doesn't seem to return anything, so I've switched the extern definition to use a return type of void.

Required for Wasm compatability.
@DavisVaughan DavisVaughan merged commit 8bbd8c4 into r-lib:main Aug 17, 2023
12 checks passed
@DavisVaughan
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants