Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InlinePickerRowFormer resets "selectedRow" back to index 0 #78

Open
Daxito opened this issue May 12, 2018 · 4 comments · May be fixed by #120
Open

InlinePickerRowFormer resets "selectedRow" back to index 0 #78

Daxito opened this issue May 12, 2018 · 4 comments · May be fixed by #120
Assignees
Labels

Comments

@Daxito
Copy link

Daxito commented May 12, 2018

Hi,
Line 79 of this file
Former/Former/RowFormers/InlinePickerRowFormer.swift
causes not being able to set selectedRow to different index:
}.configure{ $0.pickerItems = SOME_COLLECTION_WITH_100_ITEMS $0.selectedRow = 2 //<--- This is always overwritten by line 79 back to 0 }

Thanks

@croyneaus4u
Copy link

We can have a

selectedRow = 0 only when selectedRow >= pickerItems.count

IMO that would be a better approach for the fix that you have employed for index out of range

@ZacharyKhan
Copy link
Collaborator

I will look into this and get back to you shortly

@benwalch
Copy link

benwalch commented Dec 1, 2019

any news on this? same issue here. and thanks a lot for this nice piece of software!

@phr85
Copy link

phr85 commented Dec 19, 2019

@benwalch Do you found a way to fix it?

@marcheimendinger marcheimendinger linked a pull request Apr 28, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants