-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channel should extend Closable #1445
Comments
Which APIs are you referring to? |
@jhaye please submit a PR? (just to make sure: we want to keep |
Apache Commons IOUtils is a good example. |
Gladly, I was initially not sure how my employer handles contributions to OSS. I resolved that question now and will open a PR soon. Since |
Well... I overlooked that Looking over the issue tracker, it appears that a next major version is in the works. Maybe this could be adressed there? Otherwise feel free to close this. |
A A Note the phrasing and the package for each interface. We are reasoning backward if we want |
There is no ETA for 6.0. TBH, I would rather make |
Is your feature request related to a problem? Please describe.
Channel
currently only implementsAutoClosable
. It was added to the standard library as a super interface toClosable
, so that everyone could benefit from the try-with-resources feature, without changing API. This also means that pretty much all APIs designed to consume something with a close method, do so via theClosable
interface. SinceAutoClosable
is aboveClosable
in the the hierarchy, those APIs cannot work withChannel
.Describe the solution you'd like
The
Channel
interface implementsClosable
. This extends the super interface set and is thus an API compatible change.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: