Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider building thumbnails from server as a fallback if user does not provide a thumbnail #107

Open
osdiab opened this issue Sep 10, 2018 · 1 comment

Comments

@osdiab
Copy link
Member

osdiab commented Sep 10, 2018

If for a video operation thumbnailUrl isn't present, we can generate it server side.

Rahul mentions that installing imagemagick on cloud functions is a pain, which is why we decided to do it on client. Ideally they should always both be present, but supporting this might make it more robust, for instance like now when apple doesn't accept our changes so iOS doesn't upload the thumbnail.

@rahulgi
Copy link
Member

rahulgi commented Sep 10, 2018

*i vaguely remember it seeming tricky to install imagemagick on appengine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants