Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t publish server in NPM #47

Open
osdiab opened this issue Jun 15, 2018 · 2 comments
Open

Don’t publish server in NPM #47

osdiab opened this issue Jun 15, 2018 · 2 comments

Comments

@osdiab
Copy link
Member

osdiab commented Jun 15, 2018

Just publish the data model. Server doesn’t need to be npm installable

I’d also rather have that than to have a separate repo for the data model, which would work and be more modular perhaps but would make api development annoying It's kinda nice having them all in the same repo since type errors appear as soon as you change things in a breaking way across the server and client, but that would probably be the most straightforward way to achieve this.

Maybe we can achieve this by making this a monorepo instead of one NPM project—that should work fine.

@osdiab
Copy link
Member Author

osdiab commented Jul 17, 2018

cc @rahulgi I think monorepo/workspaces can work fine for this, we had a problem with monorepo with react-native since native doesn't support symlinks and monorepos depend on that. But this is isolated from react-native so it should be fine

@rahulgi
Copy link
Member

rahulgi commented Sep 29, 2018

@osdiab this is fixed, yeah?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants